Use `@JsonProperty` and lowercase feature when serializing Enums despite write using toString() #4039

iProdigy · 2023-07-14T20:04:36Z

Serialization complement of #4036

…MS_USING_TO_STRING

iProdigy · 2023-07-14T20:05:09Z

@JooHyukKim Could you also review this PR please?

src/main/java/com/fasterxml/jackson/databind/util/EnumValues.java

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java

JooHyukKim · 2023-07-15T01:08:47Z

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java

+     *
+     * @since 2.16
+     */
+    protected final EnumValues _valuesByToString;


I am not confident about readability perspective, but is it possible to use the same/similar structure as other EnumValues members' javadoc?

Appreciate the review - can you elaborate on what you mean here?

I originally thought it will be easier to read if javadoc of _values, _valuesByEnumNaming, and _valuesByToString had similarly structured paragraph and use similar terms. But can skip my comment, thanks 👍🏻

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java

Co-authored-by: Kim, Joo Hyuk <beanskobe@gmail.com>

cowtowncoder · 2023-07-15T23:23:09Z

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java

@@ -82,6 +92,20 @@ public EnumSerializer(EnumValues v, Boolean serializeAsIndex, EnumValues valuesB
        _values = v;
        _serializeAsIndex = serializeAsIndex;
        _valuesByEnumNaming = valuesByEnumNaming;
+        _valuesByToString = null;


Should just use this(v, serializeAsIndex, valuesByEnumNaming, null); ?

Also let's add @Deprecated (and Javadoc) here

cowtowncoder · 2023-07-15T23:25:03Z

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java

@@ -71,6 +80,7 @@ public EnumSerializer(EnumValues v, Boolean serializeAsIndex)
        _values = v;
        _serializeAsIndex = serializeAsIndex;
        _valuesByEnumNaming = null;
+        _valuesByToString = null;


Can just delegate (with this(v, serializeAsIndex, null, null)).

Also, unless called from non-deprecated code, let's also mark as @Deprecated // since 2.16.

cowtowncoder

Looks good; just need to add some more Deprecation markers & could chain from deprecated constructors.

Actually, I can do these post-merge, so approving & merging now.

feat: use JsonProperty and WRITE_ENUMS_TO_LOWERCASE despite WRITE_ENU…

4582a5d

…MS_USING_TO_STRING

iProdigy commented Jul 14, 2023

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/util/EnumValues.java Outdated Show resolved Hide resolved

JooHyukKim reviewed Jul 15, 2023

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java Outdated Show resolved Hide resolved

JooHyukKim reviewed Jul 15, 2023

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java Outdated Show resolved Hide resolved

JooHyukKim reviewed Jul 15, 2023

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/ser/std/EnumSerializer.java Outdated Show resolved Hide resolved

iProdigy and others added 4 commits July 14, 2023 20:20

fix: use correct value in format visitor

450b7e2

chore: reorder variable declaration in EnumSerializer.construct

52c6a24

docs: linkify Enum#toString

6049740

Co-authored-by: Kim, Joo Hyuk <beanskobe@gmail.com>

chore: remove unrelated performance optimization

c41185b

iProdigy mentioned this pull request Jul 15, 2023

feat(helix): add content classification and branded content management twitch4j/twitch4j#811

Merged

2 tasks

cowtowncoder reviewed Jul 15, 2023

View reviewed changes

cowtowncoder approved these changes Jul 15, 2023

View reviewed changes

cowtowncoder merged commit 3c48461 into FasterXML:2.16 Jul 15, 2023
3 checks passed

cowtowncoder changed the title ~~feat(enum): use JsonProperty and lowercase feature despite write using toString~~ Use @JsonProperty and lowercase feature when serializing Enums despite write using toString Jul 15, 2023

cowtowncoder changed the title ~~Use @JsonProperty and lowercase feature when serializing Enums despite write using toString~~ Use @JsonProperty and lowercase feature when serializing Enums despite write using toString() Jul 15, 2023

cowtowncoder added a commit that referenced this pull request Jul 15, 2023

Update release notes wrt #4039

ca47ea3

iProdigy deleted the fix/enum-write-tostring-jsonproperty branch July 15, 2023 23:31

cowtowncoder added a commit that referenced this pull request Jul 16, 2023

Minor additions post #4039

1ae7dc4

JooHyukKim mentioned this pull request Jul 14, 2023

Apply improved handling of Enum to all part #3990

Closed

YutaHiguchi-bsn mentioned this pull request Feb 1, 2024

Jackson 2.16 fails attempting to obtain ObjectWriter for an Enum which some value returns null from toString() #4355

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `@JsonProperty` and lowercase feature when serializing Enums despite write using toString() #4039

Use `@JsonProperty` and lowercase feature when serializing Enums despite write using toString() #4039

iProdigy commented Jul 14, 2023

iProdigy commented Jul 14, 2023

JooHyukKim Jul 15, 2023

iProdigy Jul 15, 2023

JooHyukKim Jul 15, 2023

cowtowncoder Jul 15, 2023 •

edited

cowtowncoder Jul 15, 2023

cowtowncoder left a comment

Use @JsonProperty and lowercase feature when serializing Enums despite write using toString() #4039

Use @JsonProperty and lowercase feature when serializing Enums despite write using toString() #4039

Conversation

iProdigy commented Jul 14, 2023

iProdigy commented Jul 14, 2023

JooHyukKim Jul 15, 2023

Choose a reason for hiding this comment

iProdigy Jul 15, 2023

Choose a reason for hiding this comment

JooHyukKim Jul 15, 2023

Choose a reason for hiding this comment

cowtowncoder Jul 15, 2023 • edited

Choose a reason for hiding this comment

cowtowncoder Jul 15, 2023

Choose a reason for hiding this comment

cowtowncoder left a comment

Choose a reason for hiding this comment

Use `@JsonProperty` and lowercase feature when serializing Enums despite write using toString() #4039

Use `@JsonProperty` and lowercase feature when serializing Enums despite write using toString() #4039

cowtowncoder Jul 15, 2023 •

edited