Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enum deserialization to use @JsonProperty, @JsonAlias even if EnumNamingStrategy used #4037

Conversation

iProdigy
Copy link
Contributor

@iProdigy iProdigy commented Jul 13, 2023

Similar to PropertyNamingStrategy, enum deserializer should respect @JsonProperty and @JsonAlias even when EnumNamingStrategy is active.

Related #4036

A separate PR will be created for the serialization case (this PR only covers deserialization)

@iProdigy iProdigy changed the title fix(enum): use JsonProperty and JsonAlias despite EnumNamingStrategy fix(deser): use JsonProperty and JsonAlias despite EnumNamingStrategy Jul 13, 2023
@iProdigy iProdigy marked this pull request as ready for review July 13, 2023 23:47
@iProdigy iProdigy marked this pull request as draft July 14, 2023 01:17
@iProdigy iProdigy marked this pull request as ready for review July 14, 2023 20:19
@cowtowncoder cowtowncoder changed the title fix(deser): use JsonProperty and JsonAlias despite EnumNamingStrategy Fix Enum deserialization to use @JsonProperty, @JsonAlias even if EnumNamingStrategy chosen Jul 15, 2023
@cowtowncoder cowtowncoder merged commit 2966ced into FasterXML:2.16 Jul 15, 2023
3 checks passed
@cowtowncoder cowtowncoder changed the title Fix Enum deserialization to use @JsonProperty, @JsonAlias even if EnumNamingStrategy chosen Fix Enum deserialization to use @JsonProperty, @JsonAlias even if EnumNamingStrategy used Jul 15, 2023
cowtowncoder added a commit that referenced this pull request Jul 15, 2023
@iProdigy iProdigy deleted the fix/enum-naming-strategy-jsonproperty-jsonalias branch July 15, 2023 23:16
@cowtowncoder
Copy link
Member

Thank you @iProdigy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants