Optimize ObjectNode findValue(s) and findParent(s) fast paths
#4008
Conversation
cowtowncoder
changed the title
ObjectNode findValue(s) and findParent(s) fast paths
|
Thank you @schlosna ! Merged for inclusion in 2.16.0 |
|
This is super clean improvement 👍🏻 May I ask just one question tho, in what cases could traveral (the original way) still necessary? |
|
Lookups are recursive, i.e. find at any level, not just current one. For that it's still needed. |
|
Excellent, thanks @cowtowncoder ! |
Ahhh, I totally missed that. Thank you for the explanation! 🙏🏼 |
| } | ||
| foundSoFar.add(jsonNode); | ||
| return foundSoFar; |
There was a problem hiding this comment.
And here's the problem that was reported as #4229: we are to collect ALL matches, not just main-level one
| } | ||
| foundSoFar.add(jsonNode.asText()); | ||
| return foundSoFar; |
ObjectNode::findValue(String)andObjectNode::findParent(String)currently traverse the node's children entries looking for a matchingpropertyName, leading toO(n)access time per level in anObjectNodegraph.Both of these methods could be optimized to perform a
O(1)LinkedHashMap.get(String)lookup for the fast path where givenObjectNodecontains a child property with thatpropertyName, before falling back to the slow path traversing all child values.