Add convenience method SimpleBeanPropertyFilter.filterOutAll() as symmetric counterpart of serializeAll()
#3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
changed the title
filterOutAll() method, symmetric counterpart to serializeAll() for SimpleBeanPropertyFilterSimpleBeanPropertyFilter.filterOutAll() as symmetric counterpart of SimpleBeanPropertyFilter. serializeAll()
JooHyukKim
changed the title
SimpleBeanPropertyFilter.filterOutAll() as symmetric counterpart of SimpleBeanPropertyFilter. serializeAll()SimpleBeanPropertyFilter.filterOutAll() as symmetric counterpart of serializeAll()
pjfanning
reviewed
Mar 11, 2023
src/main/java/com/fasterxml/jackson/databind/ser/impl/SimpleBeanPropertyFilter.java
Outdated
Show resolved
Hide resolved
JooHyukKim
commented
Mar 11, 2023
| SimpleBeanPropertyFilter.filterOutAll()); | ||
| assertEquals("{}", MAPPER.writer(prov).writeValueAsString(new Bean())); | ||
| } | ||
|
|
There was a problem hiding this comment.
There is testIncludeAllFilter() test right above this one. So this test case seems to belong here.
cowtowncoder
approved these changes
Mar 11, 2023
cowtowncoder
changed the title
SimpleBeanPropertyFilter.filterOutAll() as symmetric counterpart of serializeAll()SimpleBeanPropertyFilter.filterOutAll() as symmetric counterpart of serializeAll()
cowtowncoder
added a commit
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new convenience method to
SimpleBeanPropertyFilterclass, calledfilterOutAll(). The purpose of this method is to provide a symmetric counterpart to the already-existingserializeAll(), making it easier for developers to useSimpleBeanPropertyFilterclass in a more intuitive way.Changes Made
filterOutAll()method inSimpleBeanPropertyFilter.filterOutAllExcept(String...)andserializeAllExcept(String...)methods ofSimpleBeanPropertyFilterand its subclasses to ensure that they output the same JSON string.