keep bundle annotations and prevent simple cycles

[tea-dragon]

I don't see any downsides and this makes it easier to manipulate
custom annotations, introspectors, serializers, and other parts
that interact with annotated objects. The cycle detection is a
bonus.

[cowtowncoder]

Was this related to problems with multiple annotation bundles?

[tea-dragon]

In the sense that the "endless recursion" case it solves requires multiple annotation bundles, yes. The primary goal is to be able to use properties or implicit information from the annotation bundle itself.

[tea-dragon]

Please note the 'build failures' are unrelated issues present in master.

[cowtowncoder]

@tea-dragon Right, build failure is due to an unsolved problem, I need to move it under 'failing' (or fix if possible of course).

I hadn't thought about possiblity of cycles, as annotation datatypes can not have recursive notation.
But ability to attach meta-annotations does open up the door so that makes sense.

But I still don't understand the "be able to use properties or implicit information from the annotation bundle itself." part.

[tea-dragon]

There is an example in the added tests. The InformativeHolder interface has a commented property that demonstrates it.

As another example, imagine I have a custom annotation @Bytes that affects deserialization in some way. I might want to have @Bytes imply @JsonProperty to reduce annotation clutter, but if I make @Bytes an annotation bundle, then currently I won't be able to see it from the modification hooks.

[cowtowncoder]

@tea-dragon Ok thanks I will look at the test.

But on second part: which modification hooks are you referring to? Annotations from bundles should be visible from all access points, via AnnotatedXxx types.

[cowtowncoder]

Oh, I see. So, that the annotation "wrapper" itself should not be dropped, but included, not just annotations it contains. Yes, that makes sense.
And similarly about recursive annotations; this is something I hadn't thought of given that all the other types for annotations must be non-recursive.

So I finally understand all pertinent points here I think. Thank you for explanation.