Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input validation for NumberDeserializers deserializers for "stringified" FP numbers #4250

Closed
cowtowncoder opened this issue Dec 9, 2023 · 1 comment
Labels
2.17 Issues planned at earliest for 2.17
Milestone

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Dec 9, 2023

Describe your Issue

Although all decoding/parsing of true JSON numbers validates that tokens follow expected pattern, before calling number methods, deserializers in NumberDeserializers do not seem to do that for "stringified Numbers" (that is, JSON Strings that contain Numbers). But Floating Point decoders expect such validation to be done before calling methods via jackson-core package's NumberInput methods.

So let's add validation for alleged FP numbers.

@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.17 Issues planned at earliest for 2.17 and removed to-evaluate Issue that has been received but not yet evaluated labels Dec 9, 2023
@cowtowncoder cowtowncoder added this to the 2.17.0 milestone Dec 14, 2023
@cowtowncoder
Copy link
Member Author

(note: PRs that fixed this did not refer the issue, unfortunately)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.17 Issues planned at earliest for 2.17
Projects
None yet
Development

No branches or pull requests

1 participant