Fix deser of null values for collection/array type deserializers #407
Conversation
…izers * All of these deserializers should ask the encapsulated valueDeserializer for its nullValue when `VALUE_NULL` is encountered, rather than assuming a return value of `null`. * This is a bug that affects the ser/deser of `Collection[Option[_]]` in scala, as `None` values are serialized to `null` and deserialized back to `null` rather than `None`, which is correctly overriden in `OptionDeserializer` * Note I am a first time committer and happy to sign any release. Thanks!
|
Awesome! Yes, we do need the usual CLA, see: https://github.com/FasterXML/jackson (and 'contributor-agreeement.pdf` listed) Other than that, it'd be great if you could add a simple unit test; but change itself is simple enough that I don't have concern about it. Just nice to have something against regression. |
|
Forgot to mention: since there's no way (that I know of) to attach docs here, just email scanned document to 'info' at fasterxml.com, and we'll keep a copy. Let me know if you have questions. |
unit tests showing custom null deserialization of values in arrays and maps
|
@cowtowncoder Just pushed some unit tests. I'll let you know when I send the the release, still getting company approval. Thanks! |
|
Perfect! Also note that wrt CLA, you can choose to do it just as yourself; or as employee of a company. Both work for us, and both are used (we have corporate CLAs that simplify contributions by bigger companies). So you can choose based on how it relates to your work (part of work or outside). |
|
Just sent the signed CLA. Sorry for the delay! |
This will ensure that the custom OptionDeserializer is always used when deserializing Options. Right now when `List[Option[_]]` is deserialized, the Option class is treated as a "simple" type in the constructed `JavaType` and thus a generic JSON Deserializer is used rather than `OptionDeserializer`. Note that the new test will NOT pass until a jackson-databind dependency with FasterXML/jackson-databind#407 is used
Fix deser of null values for collection/array type deserializers
|
It doesn't look like this patch made it into 2.3.2, correct? |
|
@christophercurrie It should have made it in 2.3.2. |
|
I might be missing something, because I don't see the relevant commits on the databind 2.3 branch, and the test for FasterXML/jackson-module-scala#132 does not pass when I merge it into the 2.3 branch there. I'll hold off releasing 2.3.2 of the Scala module in case I've missed something critical. |
|
No, you are right. I did not consider the part of backporting; I do merge my own fixes, but for pull requests usually ask submitter. But not here. |
VALUE_NULLis encountered, rather than assuming a return value ofnull.Collection[Option[_]]in scala, asNonevalues are serialized tonulland deserialized back tonullrather thanNone, which is correctly overridden inOptionDeserializer