Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JsonNode.with() with JsonNode.withObject() #3535

Closed
cowtowncoder opened this issue Jul 3, 2022 · 0 comments
Closed

Replace JsonNode.with() with JsonNode.withObject() #3535

cowtowncoder opened this issue Jul 3, 2022 · 0 comments
Milestone

Comments

@cowtowncoder
Copy link
Member

Currently JsonNode has 2 related methods:

  • with(String) which is to be called on JSON Object node, and find-or-create a JSON Object node of given property
  • withArray(String) which is to be called on JSON Object, and find-or-create a JSON Array node of given property

Now that we are about to implement #1980, it looks like with() is unnecessarily ambiguous and it'd be better to have slightly longer but more meaningful name of withObject(). This can be done by adding the new method and deprecating old one; old method needs to be left for the remainder of 2.x series but then dropped from 3.0.

@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.14 and removed to-evaluate Issue that has been received but not yet evaluated labels Jul 3, 2022
@cowtowncoder cowtowncoder added this to the 2.14.0 milestone Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant