Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenBuffer defaults for parser/stream-read features neither passed from parser nor use real defaults #3528

Closed
cowtowncoder opened this issue Jun 25, 2022 · 2 comments
Milestone

Comments

@cowtowncoder
Copy link
Member

It looks like TokenBuffer explicitly passes 0 for "parser feature flags" from its constructor. This is wrong; it should either:

  • Ideally pass flags of JsonParser it is constructed with (if any), OR
  • Defaults combined from features in question (same as what JsonParser defaults to)

At first it is probably necessary to just do latter.

@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.14 and removed to-evaluate Issue that has been received but not yet evaluated labels Jun 25, 2022
@cowtowncoder cowtowncoder added this to the 2.14.0 milestone Jun 25, 2022
@cowtowncoder
Copy link
Member Author

Fix for 2.x simply sets parser/stream-read features to defaults; no way to (yet) pass real values from parser being buffered.

3.x could likely work better but I might not have time to tackle that yet; should be no worse than 2.x for time being.

@cowtowncoder
Copy link
Member Author

3.x may already work better, but no tests to verify. Should, in general, test combination of Feature settings, overrides, better for 3.0 since it is capable of more accurately handling things.

But for now this has to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant