Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SerializerProvider as SerializationContext (for 3.0) #3043

Open
cowtowncoder opened this issue Feb 4, 2021 · 0 comments
Open

Rename SerializerProvider as SerializationContext (for 3.0) #3043

cowtowncoder opened this issue Feb 4, 2021 · 0 comments
Labels

Comments

@cowtowncoder
Copy link
Member

Something that should have been done during 1.x->2.0 major version upgrade but better late than never: due to historical reasons (serialization implemented before deserialization), context object naming is inconsistent. We have:

  • DeseralizationContext for deserialization
  • SerializerProvider for serialization

Latter may have made sense in 0.9.4 since the primary reason was access to child serializers (and this is still an importan use case); but conceptually it is a context object, and has expanded a lot in functionality.
So let's fix this naming discrepancy in 3.0.
(yes, this will result in lots of changes across the whole codebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant