Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with implicit creator name detection for constructor detection #2932

Closed
cowtowncoder opened this issue Nov 10, 2020 · 2 comments
Closed

Problem with implicit creator name detection for constructor detection #2932

cowtowncoder opened this issue Nov 10, 2020 · 2 comments
Labels
has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue
Milestone
2.12.0

Comments

@cowtowncoder
Copy link
Member

(note: originally FasterXML/jackson-modules-java8#178)

So looks like detection of "implicit" creator property name gets masked by bogus name detected for annotations like @JsonDeserialize in some cases: specifically, if no @JsonCreator annotation is used. If so, deserializer factory's logic seems to consider empty name returned to mean "no name exists".
@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.13 and removed to-evaluate Issue that has been received but not yet evaluated labels Nov 10, 2020
@cowtowncoder cowtowncoder mentioned this issue Nov 10, 2020
Closed
cowtowncoder added a commit that referenced this issue Nov 10, 2020
@cowtowncoder
Add (failing) test for #2932
74f0f44
cowtowncoder added a commit that referenced this issue Nov 10, 2020
@cowtowncoder
add passing tests for #2932
1a994c8
@cowtowncoder cowtowncoder added the has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue label Nov 17, 2020
@cowtowncoder
Copy link
Member Author

Looks like logic to change is in method _checkImplicitlyNamedConstructors() of BasicDeserializerFactory...

@cowtowncoder cowtowncoder removed the 2.13 label Sep 24, 2022
@cowtowncoder
Copy link
Member Author

Fix included in 2.12.0.

@cowtowncoder cowtowncoder added this to the 2.12.0 milestone Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
1 participant
@cowtowncoder