Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to ensure EnumSet and EnumMap work correctly with "null-as-empty" #2529

Closed
cowtowncoder opened this issue Oct 28, 2019 · 1 comment
Closed

Add tests to ensure EnumSet and EnumMap work correctly with "null-as-empty" #2529

cowtowncoder opened this issue Oct 28, 2019 · 1 comment
Milestone
2.10.1

Comments

@cowtowncoder
Copy link
Member

While null-handling with @JsonSetter is tested to a degree, Enum collections (EnumSet, EnumMap) have quite particular handling (due to JDK implementation details), and should probably be separately and explicitly tested.
@cowtowncoder
Copy link
Member Author

Looks like handling by EnumMap is correct, but EnumSet needs to be tweaked: both wrt empty value for itself and handling of null as contents (will not be possible to "use empty", but should be possible to skip).

cowtowncoder added a commit that referenced this issue Oct 29, 2019
@cowtowncoder
First fix wrt #2529 tests: support mapping null for EnumSet as em…
9432f40 
…pty set.
@cowtowncoder cowtowncoder added this to the 2.10.1 milestone Oct 29, 2019
@cowtowncoder cowtowncoder changed the title Add a tests to ensure EnumSet and EnumMap work correctly with "null-as-empty" Add tests to ensure EnumSet and EnumMap work correctly with "null-as-empty" Oct 29, 2019
@cowtowncoder cowtowncoder mentioned this issue Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.1
Development

No branches or pull requests
1 participant
@cowtowncoder