Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of DeserializerCache, auto-flush on exceeding #1995

Closed
cowtowncoder opened this issue Apr 11, 2018 · 2 comments
Closed

Limit size of DeserializerCache, auto-flush on exceeding #1995

cowtowncoder opened this issue Apr 11, 2018 · 2 comments
Milestone

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Apr 11, 2018

(note: offshoot of #1905)

Currently size of deserializer cache is not bounded: this is something that goes against the cardinal rule of caches ("never use unbounded caches for unbounded domain").
This needs to go in 3.0 because tweaks to caching are generally high-risk changes.

@cowtowncoder
Copy link
Member Author

As with serializer caching, start with max of 4000 entries; probably bigger than necessary, but most important to be bound for now.

@cowtowncoder
Copy link
Member Author

Changed to 2000; backporting in 2.10.

cowtowncoder added a commit that referenced this issue Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant