Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for "default [Map] key serializer" configuration from SerializerProvider #1973

Closed
cowtowncoder opened this issue Mar 16, 2018 · 0 comments
Labels
Milestone

Comments

@cowtowncoder
Copy link
Member

One goal of 3.0 is to simplify APIs, including configuration; as well as to change key entities immutable where possible. One of legacy one-off features has been ability to specify a single fallback serializer to be used for Map key types for which no key serializer can be located using other facilities, such as pluggable modules.

But with combination of much extended standard key serializers and flexibility of Modules, this feature seems obsolete by now. Worse, it is part of mutable configuration of SerializerProvider, beyond basic blueprint/instance setup that we want to support (where SerializerProvider [which ought to be named "SerializationContext", is per-call state; separate from stable SerializationConfig`).

So: let's eliminate this first. Then we can see what to do with custom null key / null serializer handlers.

@cowtowncoder cowtowncoder added this to the 3.0.0 milestone Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant