Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1313: New IgnoreCase feature to deserialize enums #1520

Merged
merged 1 commit into from Feb 23, 2017

Conversation

AnaEliza
Copy link
Contributor

@AnaEliza AnaEliza commented Feb 7, 2017

Please let me know if there is something to fix here!
BR.

@cowtowncoder
Copy link
Member

@AnaEliza Thank you for contributing this! I hope to review this soon, and form quick glance it makes sense.

One (and only) formality we have, before I can merge the patch, is to have a Contributor License Agreement (CLA) filled. It's a short document that affirms that contributor can make contribution under expected terms, and only needs to be filled once for all Jackson projects.
And it keeps legal folks happy (we wouldn't care otherwise) :)

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

The usual way is to print it, fill & sign, scan and email to info at fasterxml.com.

Apologies for having to do this, but it really is just one-time thing.

Thank you once again for contributing the patch!

@AnaEliza
Copy link
Contributor Author

@cowtowncoder Hey! I just sent the CLA. Sorry for the huge delay!!!

@cowtowncoder
Copy link
Member

@AnaEliza No problem, got it, will proceed with merging now.

@cowtowncoder cowtowncoder merged commit 15d4fe2 into FasterXML:master Feb 23, 2017
@cowtowncoder cowtowncoder added this to the 2.9.0 milestone Feb 23, 2017
@cowtowncoder
Copy link
Member

Actually: I will make one change here -- instead of DeserializationFeature, I'll change this to MapperFeature to be consistent with existing MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES, so we'll have:

MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS

Change will be in 2.9.0.pr3

cowtowncoder added a commit that referenced this pull request Mar 30, 2017
@tea-dragon
Copy link
Contributor

Mmm this will let me delete another wrapper class. Thanks.

@nicolasmafra
Copy link

How to use MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS with @jsonformat or similar annotation?

@cowtowncoder
Copy link
Member

@nickmafra I think that would be by using JsonFormat.Feature.ACCEPT_CASE_INSENSITIVE_VALUES; description suggests it works for Enums too. If not, could you file a new issue pointing out it does not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants