Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BigDecimalParser for BigInteger parsing very long numbers #814

Closed
pjfanning opened this issue Sep 21, 2022 · 2 comments
Closed

Use BigDecimalParser for BigInteger parsing very long numbers #814

pjfanning opened this issue Sep 21, 2022 · 2 comments
Labels
2.14 Issue planned (at earliest) for 2.14
Milestone
2.14.0

Comments

@pjfanning
Copy link
Member

Maybe something for jackson 2.15. Relates to #813

String to BigInteger support is currently done using new BigInteger(str).

BigDecimalParser has some performance related code for handling numbers with many digits. #813 suggests that we might be able to get improvements in performance and error handling by using some ideas from jsoniter_scala. BigInteger could probably benefit from these too.

@plokhotnyuk fyi
@cowtowncoder cowtowncoder added the 2.15 Issue planned (at earliest) for 2.15 label Sep 23, 2022
This was referenced Oct 21, 2022
Closed
Merged
@pjfanning
Copy link
Member Author

@cowtowncoder could we consider #826 as a late breaking change for Jackson 2.14.0?

@cowtowncoder cowtowncoder added 2.14 Issue planned (at earliest) for 2.14 and removed 2.15 Issue planned (at earliest) for 2.15 labels Oct 22, 2022
@cowtowncoder cowtowncoder added this to the 2.14.0 milestone Oct 22, 2022
@cowtowncoder cowtowncoder changed the title use BigDecimalParser for BigInteger parsing Use BigDecimalParser for BigInteger parsing very long numbers Oct 22, 2022
cowtowncoder added a commit that referenced this issue Oct 22, 2022
@cowtowncoder
Update release notes wrt #814
93a5474
@cowtowncoder
Copy link
Member

@pjfanning Considering everything else, I think that's safe enough so merged PR to get this improvement in.
I do need to stop merging things of course, but this seemed like non-problematic thing even if last minute.

@cowtowncoder cowtowncoder mentioned this issue Apr 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.14 Issue planned (at earliest) for 2.14
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@cowtowncoder @pjfanning