Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception/JsonLocation handling for binary content: don't show content, include byte offset #694

Closed
cowtowncoder opened this issue Apr 4, 2021 · 0 comments

Comments

@cowtowncoder
Copy link
Member

(note: related to #658, partly #652)

With Jackson 2.12 and earlier inclusion of content snippet for exception messages does not differentiate between textual (json, xml, csv for example) and binary (smile, cbor, for example) content. This leads to attempts to print out control characters for binary content: something that has little value but can be annoying and possibly even unsafe in some cases.
Additionally attempt to print out column/row location are futile as binary formats do not have these concepts.

For 2.13 let's change things so that:

  1. No content snippet is included (at least by default: may consider inclusion of hex values or something later on)
  2. Location information will refer to byte offset (relative to start of content), not row/column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant