Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonGenerator#writeNumber(char[], int, int) method #587

Closed
vy opened this issue Dec 29, 2019 · 0 comments
Closed

Add JsonGenerator#writeNumber(char[], int, int) method #587

vy opened this issue Dec 29, 2019 · 0 comments
Milestone
2.11.0

Comments

@vy
Copy link
Contributor

vy commented Dec 29, 2019 •
edited

As discussed in the relevant jackson-user thread, JsonGenerator#writeNumber() method lacks support for char[]. Introducing a JsonGenerator#writeNumber(char[] buffer, int offset, int length) will enable users to write numbers in their preferred format without incurring an extra allocation cost, e.g., as in JsonGenerator#writeNumber(String).

Note that #577 and #514 are relevant issues addressing a similar concern in broader sense.
vy added a commit to vy/jackson-core that referenced this issue Jan 2, 2020
@vy
Add JsonGenerator#writeNumber(char[],int,int) method for FasterXML#587.
b95279e
vy added a commit to vy/jackson-core that referenced this issue Jan 2, 2020
@vy
Add JsonGenerator#writeNumber(char[],int,int) method for FasterXML#587.
0e05e6f
@cowtowncoder cowtowncoder added this to the 2.11.0 milestone Jan 10, 2020
cowtowncoder pushed a commit that referenced this issue Jan 10, 2020
@vy @cowtowncoder
test for #587 (#589)
de07f1c 
Fix #587 Add JsonGenerator#writeNumber(char[],int,int) methods, tests
cowtowncoder added a commit that referenced this issue Jan 10, 2020
@cowtowncoder
Backport #587 impl, minor changes, add release notes
36a4195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
2 participants
@cowtowncoder @vy