Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indication of "source reference" in JsonLocation wrt byte[],char[] #356

Closed
cowtowncoder opened this issue Feb 23, 2017 · 1 comment
Milestone

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Feb 23, 2017

(note: inspired by #343)

Since we already include contents when read from String, it seems reasonable to do about the same for byte[] (assume UTF-8) and char[] sources.
But it'd also make sense to add a JsonParser.Feature to allow disabling inclusion of content, for security reasons.

@cowtowncoder cowtowncoder added this to the 2.9.0 milestone Feb 23, 2017
@cowtowncoder
Copy link
Member Author

Added JsonParser.Feature.INCLUDE_SOURCE_IN_LOCATION (default: true), disabling of which will prevent addition of source reference, usually for security reasons.

Also: maximum content snippet displayed limited to 500 characters.

@cowtowncoder cowtowncoder changed the title Improve indication of "source" for errors wrt byte[],char[] / JsonLocation Improve indication of "source reference" for errors wrt byte[],char[] / JsonLocation Feb 23, 2017
@cowtowncoder cowtowncoder changed the title Improve indication of "source reference" for errors wrt byte[],char[] / JsonLocation Improve indication of "source reference" in JsonLocation wrt byte[],char[] Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant