issue #15 - readtext in jsonparser #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if(t != null) { | ||
| switch (t.id()) { | ||
| case ID_FIELD_NAME: | ||
| writer.write(_parsingContext.getCurrentName()); |
There was a problem hiding this comment.
These cases also need to indicate amount of content written (len)
|
Looks good; I can add |
|
Actually I'll go ahead and rename this method as Also I need to add default impl as well as efficient definitions for all other data formats: this is why default implementation is important (instead of new abstract method), so as not to break many existing dataformat modules. Thank you again for contributing this! |
cowtowncoder
added a commit
that referenced
this pull request
May 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the readText(writer) which reads the character segments and writes to the given writer object.
Fixed the review comments from previous PR.
I have changed the api now for readText(Writer) to return the number of bytes read instead of true and false as we are reading all the contents at once.
Let me know if this is fine.