Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of _matchCount in FilteringParserDelegate #208

Closed
zazi opened this issue Aug 4, 2015 · 4 comments
Closed

Make use of _matchCount in FilteringParserDelegate #208

zazi opened this issue Aug 4, 2015 · 4 comments
Milestone

Comments

@zazi
Copy link

zazi commented Aug 4, 2015

Currently, it looks like that the _matchCount attribute in FilteringGeneratorDelegate is not utilised (i.e. no value is assigned to this variable). Re. the documentation this attribute offers some useful functionality. So it would be nice, if it could be implemented properly. See https://groups.google.com/d/msg/jackson-user/VzZ94G9hvrs/JGFozl6lCQAJ

@cowtowncoder cowtowncoder changed the title make use of _matchCount in FilteringGeneratorDelegate make use of _matchCount in FilteringParserDelegate Dec 12, 2015
@cowtowncoder
Copy link
Member

Had a quick look to try to see how easy it would be to add this, and my head is hurting now. Code gets complicated pretty quickly, and although some aspects (zero vs some matches) would be doable, it gets tricky to properly update it with sub-tree matches. So I'll need to spend more time at some point to do it right.

rfoltyns added a commit to rfoltyns/jackson-core that referenced this issue May 27, 2017
@rfoltyns
Copy link
Contributor

@cowtowncoder I gave it a try. Please have a look.

@cowtowncoder
Copy link
Member

@rfoltyns Could you create a Pull Request for this?

rfoltyns added a commit to rfoltyns/jackson-core that referenced this issue May 30, 2017
@rfoltyns
Copy link
Contributor

Sure. Done. I had to remove a couple of tests after 330 revert, but it still does the job.

cowtowncoder added a commit that referenced this issue Jun 6, 2017
…count

#208 FilteringParserDelegate match count support
@cowtowncoder cowtowncoder changed the title make use of _matchCount in FilteringParserDelegate Make use of _matchCount in FilteringParserDelegate Jun 6, 2017
@cowtowncoder cowtowncoder added this to the 2.9.0.pr4 milestone Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants