Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonFactory.setStreamReadConstraints(StreamReadConstraints) fails to update "maxNameLength" for symbol tables #1207

Closed
cowtowncoder opened this issue Jan 31, 2024 · 0 comments
Closed

JsonFactory.setStreamReadConstraints(StreamReadConstraints) fails to update "maxNameLength" for symbol tables #1207

cowtowncoder opened this issue Jan 31, 2024 · 0 comments
Labels
2.17 Issues planned (at earliest) for 2.17

Comments

@cowtowncoder
Copy link
Member

(note: off-shoot of a comment on #1001)

As reported by @denizk there is a problem in applying overrides for one of constraints:

JsonFactory.setStreamReadConstraints(StreamReadConstraints.builder().maxNameLength(100_000).build());

does not update symbol table set by:

JsonFactory._rootCharSymbols = CharsToNameCanonicalizer.createRoot(this);

and only Builder-based alternative works.
It should be possible to apply constraints with setStreamReadConstraints() too.
cowtowncoder added a commit that referenced this issue Jan 31, 2024
@cowtowncoder
Fixes #1207: apply "maxNameLength" change to CharsToNameCaonicalizer
224ae67
@cowtowncoder cowtowncoder added the 2.17 Issues planned (at earliest) for 2.17 label Jan 31, 2024
@wendigo wendigo mentioned this issue Mar 18, 2024
Merged
wendigo pushed a commit to wendigo/airlift that referenced this issue Mar 18, 2024
@losipiuk @wendigo
Update Jackson to 2.17.0
e3aca9c 
Add a test to ensure that setting limits for JSON is respected
when setReadContraints method is used.

FasterXML/jackson-core#1207
@wendigo wendigo mentioned this issue Mar 18, 2024
Closed
wendigo pushed a commit to wendigo/airlift that referenced this issue Mar 18, 2024
@losipiuk @wendigo
Update Jackson to 2.17.0
d2438d9 
Add a test to ensure that setting limits for JSON is respected
when setReadContraints method is used.

FasterXML/jackson-core#1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.17 Issues planned (at earliest) for 2.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder