Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new OptBoolean valued property in @JsonTypeInfo to allow per-type configuration of strict type id handling #223

Merged
merged 2 commits into from May 16, 2023
Merged

Add new OptBoolean valued property in @JsonTypeInfo to allow per-type configuration of strict type id handling #223

merged 2 commits into from May 16, 2023

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Apr 21, 2023 •
edited

As part of FasterXML/jackson-databind#3891 and resolves part of FasterXML/jackson-databind#3877, this PR will stay draft until version 2.16.

@JooHyukKim JooHyukKim changed the title Add new OptBoolean valued property in @JsonTypeInfo to allow per-type configuration of strict type id handling Add new OptBoolean valued property in @JsonTypeInfo to allow per-type configuration of strict type id handling Apr 21, 2023
@JooHyukKim JooHyukKim changed the title Add new OptBoolean valued property in @JsonTypeInfo to allow per-type configuration of strict type id handling Add new OptBoolean valued property in @JsonTypeInfo to allow per-type configuration of strict type id handling Apr 21, 2023
@JooHyukKim JooHyukKim mentioned this pull request Apr 21, 2023
Merged
@JooHyukKim JooHyukKim changed the base branch from 2.15 to 2.16 April 24, 2023 10:37
@JooHyukKim
Add attribute to JsonTypeInfo
7a86901 
Sqaushed followings:
- Clean up pom.xml changes
- Update JsonTypeInfo.java
- Clean up changes
- Update JsonTypeInfo.java
@JooHyukKim JooHyukKim marked this pull request as ready for review April 24, 2023 10:52
JooHyukKim
JooHyukKim commented Apr 24, 2023
View reviewed changes
src/main/java/com/fasterxml/jackson/annotation/JsonTypeInfo.java
@@ -313,7 +313,7 @@ public enum As {
*
* @since 2.5
public boolean skipWritingDefault() default false;
/*
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above JavaDoc was not closed properly. Maybe we can take this further to remove the comment from year 2014, since it is version-controlled?

jackson-annotations/src/main/java/com/fasterxml/jackson/annotation/JsonTypeInfo.java

Lines 306 to 316 in ae0d9f6

// 19-Dec-2014, tatu: Was hoping to implement for 2.5, but didn't quite make it.
// Hope for better luck with 2.8 or later
/**
* Property that defines whether type serializer is allowed to omit writing
* of type id, in case that value written has type same as {@link #defaultImpl()}.
* If true, omission is allowed (although writer may or may not be able to do that);
* if false, type id should always be written still.
*
* @since 2.5
public boolean skipWritingDefault() default false;
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removal

@cowtowncoder cowtowncoder merged commit 624bbef into FasterXML:2.16 May 16, 2023
2 checks passed
cowtowncoder added a commit that referenced this pull request May 16, 2023
@cowtowncoder
Update release notes wrt #223
bc55418
@cowtowncoder cowtowncoder mentioned this pull request May 16, 2023
Closed
@JooHyukKim JooHyukKim mentioned this pull request May 16, 2023
Merged
@JooHyukKim JooHyukKim deleted the reaquire-type-id branch May 19, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
2.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JooHyukKim @cowtowncoder